improvement(deployments): bugfixes for run-block, airtable + external sub management by icecrasher321 · Pull Request #5680 · simstudioai/sim

icecrasher321 · 2026-07-15T00:02:09Z

Summary

Make deployment status truthful end-to-end: deployments now move through an explicit state machine (preparing → activating → active / failed / superseded) backed by an outbox with inline-first execution, so a version is only reported live once its webhooks, schedules, and external subscriptions actually exist. Webhook registration is rebuilt on stable, generation-fenced rows with create-before-delete cutover — a failed deploy can no longer take down the currently live version, leave ghost registrations that wedge future deploys, or silently swallow provider errors (now surfaced in the deploy modal, versions list, and API responses).

Type of Change

Bug fix

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-15T00:02:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 16, 2026 12:29am

…ment-bugs # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

cursor · 2026-07-15T00:22:27Z

PR Summary

High Risk
Touches deployment orchestration, execution ingress (webhooks/schedules/MCP), and fork rollback cutover—incorrect gating could block deploys or run wrong workflow versions.

Overview
Deployment APIs, MCP, chat updates, and the deploy modal now treat live as an active version snapshot with activeDeployment / latestDeploymentAttempt (preparing, activating, active, failed)—not the legacy workflow.isDeployed flag. Deploy and promote responses expose attempt state; chat PATCH skips redundant redeploys, returns 409 while an attempt is in flight, and only persists after cutover is active.

MCP and workflow execute pin runs to the admitted deploymentVersionId; background webhook and schedule jobs honor that version, skip undeployed workflows, and tighten schedule claims with deploymentOperationId. Webhook cron/target queries use deliverableWebhookPredicate. Fork rollback drives reactivation through the deployment outbox, reports pendingActivations, and keeps the undo point until activations settle.

Also adds grain_v2 (event-type webhooks, new triggers, AI action items), extends Airtable typecast to all write ops, and normalizes else branch handling via isElseConditionTitle in the editor and executor.

^{Reviewed by Cursor Bugbot for commit 11bb86d. Configure here.}

icecrasher321 · 2026-07-15T01:11:06Z

bugbot run

icecrasher321 · 2026-07-15T01:11:10Z

@greptile

greptile-apps · 2026-07-15T01:14:06Z

Greptile Summary

This PR makes deployment status follow the real deployment lifecycle. The main changes are:

Operation-backed deploy preparation and activation.
Generation-fenced webhook registration and cleanup.
Pinned MCP execution against deployment snapshots.
Updated deployment API responses and UI status states.
Airtable typecast support for create and update tools.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/lib/webhooks/deploy.ts	Adds stable webhook preparation and version-scoped cleanup for deployment operations.
apps/sim/lib/workflows/deployment-outbox.ts	Adds deployment preparation, readiness checkpoints, activation, cleanup, and post-activation side effects.
apps/sim/lib/workflows/persistence/deployment-operations.ts	Adds deployment operation generation, status transitions, activation guards, and superseding behavior.
apps/sim/app/api/mcp/serve/[serverId]/route.ts	Pins MCP tool execution requests to the active deployment version at call time.
apps/sim/app/api/workflows/[id]/execute/route.ts	Restricts deployment snapshot execution to the internal MCP bridge path.

_{Reviews (2): Last reviewed commit: "address comments" | Re-trigger Greptile}

icecrasher321 · 2026-07-15T03:11:28Z

bugbot run

icecrasher321 · 2026-07-15T03:11:32Z

@greptile

icecrasher321 · 2026-07-15T09:21:51Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 7ffd781. Configure here.}

…ment-bugs # Conflicts: # apps/sim/background/tiktok-webhook-targets.ts

…iggers" This reverts commit c89660c.

icecrasher321 · 2026-07-15T21:44:25Z

bugbot run

icecrasher321 · 2026-07-15T22:18:06Z

bugbot run

icecrasher321 · 2026-07-15T22:36:08Z

bugbot run

icecrasher321 · 2026-07-16T00:14:24Z

bugbot run

icecrasher321 · 2026-07-16T00:30:03Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 11bb86d. Configure here.}

icecrasher321 added 2 commits July 14, 2026 13:15

improvement(webhooks): external subscription management

6382eb5

ui/ux

ff0aed0

icecrasher321 added 2 commits July 14, 2026 17:06

Merge remote-tracking branch 'origin/staging' into improvement/deploy…

cf11ff1

…ment-bugs # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

remove test file

233b307

icecrasher321 marked this pull request as ready for review July 15, 2026 00:22

cursor Bot reviewed Jul 15, 2026

View reviewed changes

vercel Bot deployed to Preview July 15, 2026 00:26 View deployment

fix tests

bcc53f3

vercel Bot temporarily deployed to Preview July 15, 2026 01:10 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/app/api/chat/manage/[id]/route.ts

greptile-apps Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/persistence/deployment-operations.ts

Comment thread apps/sim/lib/workflows/deployment-outbox.ts

Comment thread apps/sim/lib/workflows/deployment-outbox.ts

Comment thread apps/sim/app/api/mcp/serve/[serverId]/route.ts

address comments

341b7e3

vercel Bot temporarily deployed to Preview July 15, 2026 03:11 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/ee/workspace-forking/lib/promote/reactivate-in-tx.ts

Comment thread apps/sim/app/api/mcp/serve/[serverId]/route.ts

address comments

7ffd781

vercel Bot temporarily deployed to Preview July 15, 2026 09:21 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

MicaelaLuna96 reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/docs/content/docs/en/integrations/airtable.mdx

icecrasher321 added 2 commits July 15, 2026 14:16

update to grain v2 api

a20f751

improvement(grain): hide auto-registered webhook URL on v2 triggers

c89660c

vercel Bot deployed to Preview July 15, 2026 21:21 View deployment

Merge remote-tracking branch 'origin/staging' into improvement/deploy…

0a47bce

…ment-bugs # Conflicts: # apps/sim/background/tiktok-webhook-targets.ts

Revert "improvement(grain): hide auto-registered webhook URL on v2 tr…

19ef1fb

…iggers" This reverts commit c89660c.

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/app/api/chat/manage/[id]/route.ts

vercel Bot deployed to Preview July 15, 2026 21:49 View deployment

address comments

d74c91b

vercel Bot temporarily deployed to Preview July 15, 2026 22:18 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/orchestration/deploy.ts

address comments

9298bf3

vercel Bot temporarily deployed to Preview July 15, 2026 22:35 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/ee/workspace-forking/lib/promote/reactivate-in-tx.ts

Comment thread apps/sim/blocks/blocks/grain.ts

icecrasher321 added 2 commits July 15, 2026 16:09

address rollback

0eb49fd

fix grain v2

8ed3e1b

cursor Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread ...]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

Comment thread apps/sim/ee/workspace-forking/lib/promote/rollback.ts Outdated

vercel Bot deployed to Preview July 16, 2026 00:18 View deployment

fix more comments

11bb86d

vercel Bot temporarily deployed to Preview July 16, 2026 00:29 Inactive

cursor Bot reviewed Jul 16, 2026

View reviewed changes

icecrasher321 merged commit 54b35a4 into staging Jul 16, 2026
17 checks passed

waleedlatif1 deleted the improvement/deployment-bugs branch July 16, 2026 02:24

Uh oh!

Conversation

icecrasher321 commented Jul 15, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 16, 2026

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 16, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jul 15, 2026 •

edited

Loading

cursor Bot commented Jul 15, 2026 •

edited

Loading

greptile-apps Bot commented Jul 15, 2026 •

edited

Loading